git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] read-cache: increase write buffer size

From
Duy Nguyen <pclouds@gmail.com>
Date
Mar 19, 2016, 11:18 UTC
Message-ID
<CACsJy8ABvs822-vtELCm2wvvpxRV6wtEEr5Ge1qxH_zOcqdwSA@mail.gmail.com>
In-Reply-To
<1458350341-12276-1-git-send-email-dturner@twopensource.com>
On Sat, Mar 19, 2016 at 8:19 AM, David Turner <dturner@twopensource.com> wrote:
Show 6 quoted lines
> Each write() has syscall overhead, and writing a large index entails
> many such calls.  A larger write buffer reduces the overhead,
> leading to increased performance.
>
> On my repo, which has an index size of 30m, this saves about 10ms of
> time writing the index.

I wonder if split-index does not work as intended. Because if it does, you should rarely need to write that such big index files (or is this 30mb the small part and the base index is even bigger?).

But I agree with Torsten that we should make this configurable, preferably via config file, if not we can still move this define back in Makefile, overridable using config.mak

-- 
Duy
Previous: Pranit BauvaNext: David Turner
Message 4 of 5 in “read-cache: increase write buffer size”
  1. read-cache: increase write buffer sizeDavid Turner, Mar 19, 2016
  2. Torsten BögershausenMar 19, 2016
  3. Pranit BauvaMar 19, 2016
  4. Duy NguyenMar 19, 2016
  5. David TurnerMar 21, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.