Re: [PATCH/RFC] get_oid: new extended SHA-1 syntax to control resolution process

From: Duy Nguyen <pclouds@gmail.com>
Date: Jun 27, 2019, 02:52 UTC
Message-ID: <CACsJy8AB+YVNi07G-nFkEhexyo2TG=qeNLT=JLksDVnDvs0gxg@mail.gmail.com>
In-Reply-To: <xmqqk1d8ch9g.fsf@gitster-ct.c.googlers.com>

On Thu, Jun 27, 2019 at 1:51 AM Junio C Hamano <gitster@pobox.com> wrote:

Show 8 quoted lines

> > - <ref>@{literal} only accepts full ref. No turning "master" into
> >   "refs/heads/master".
>
> This is already doable by saying "refs/heads/master", isn't it?  Any
> ambiguous ones like a branch or a tag whose name is 'refs/heads/master'
> (i.e. refs/heads/refs/heads/master and refs/tags/refs/heads/master
> respectively) won't interfere once you use the explicit prefix refs/
> like so.  I'd rather not to see this one added.

If refs/heads/master does _not_ exist, then ref/heads/master can resolve to refs/heads/refs/heads/master, which I think is unexpected. "ref not found" error or something should be returned instead.

-- 
Duy