git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] branch: colour upstream branches

From
Duy Nguyen <pclouds@gmail.com>
Date
Apr 15, 2013, 12:16 UTC
Message-ID
<CACsJy8A9ii475i98n39HFMjRqBRHnoywn03k03qcbesJYbGUGA@mail.gmail.com>
In-Reply-To
<1365993469-6874-1-git-send-email-felipe.contreras@gmail.com>

On Mon, Apr 15, 2013 at 12:37 PM, Felipe Contreras <felipe.contreras@gmail.com> wrote:

Show 7 quoted lines
> @@ -417,36 +421,54 @@ static void fill_tracking_info(struct strbuf *stat, const char *branch_name,
>         int ours, theirs;
>         char *ref = NULL;
>         struct branch *branch = branch_get(branch_name);
> +       struct strbuf fancy;
> +
> +       strbuf_init(&fancy, 0);

Nitpick. You could have done "struct strbuf fancy = STRBUF_INIT;". No need to resend, I think, unless there are other changes. -- Duy

Previous: Junio C Hamano
Message 3 of 3 in “branch: colour upstream branches”
  1. branch: colour upstream branchesFelipe Contreras, Apr 15, 2013
  2. Junio C HamanoApr 15, 2013
  3. Duy NguyenApr 15, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.