git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: bug?: git grep HEAD with exclude in pathspec not taken into account

From
Duy Nguyen <pclouds@gmail.com>
Date
Oct 27, 2018, 14:57 UTC
Message-ID
<CACsJy8A83_Jh4GmVYXS-zk_6Yro6eeB9i_J7xh3VMTkr8JVDvA@mail.gmail.com>
In-Reply-To
<CAGOLd-5Gbt6fQTvm+7018uX+8WF7NUWpa1sFWAg3-5bxtmOt-Q@mail.gmail.com>

On Wed, Oct 24, 2018 at 4:55 PM Christophe Bliard <christophe.bliard@trux.info> wrote:

Show 5 quoted lines
>
> Hi,
>
> I observed an unexpected behavior while using git grep with both git
> 2.19.1 and 2.14.3.

Quick note. I confirm this is a bug in tree_entry_interesting() perhaps being over-optimistic. It'll take me more time to familiarize myself with this negative matching in the function before I come up with a fix for it. Thanks for reporting.

-- 
Duy
Previous: Christophe BliardNext: Nguyễn Thái Ngọc Duy
Message 4 of 10 in “Re: bug?: git grep HEAD with exclude in pathspec not taken into account”
  1. Christophe BliardOct 24, 2018
  2. Duy NguyenOct 24, 2018
  3. Christophe BliardOct 24, 2018
  4. Duy NguyenOct 27, 2018
  5. tree-walk.c: fix overoptimistic inclusion in :(exclude) matchingNguyễn Thái Ngọc Duy, Nov 3, 2018
  6. Eric SunshineNov 4, 2018
  7. Eric SunshineNov 4, 2018
  8. Duy NguyenNov 4, 2018
  9. tree-walk.c: fix overoptimistic inclusion in :(exclude) matchingNguyễn Thái Ngọc Duy, Nov 4, 2018
  10. Junio C HamanoNov 5, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.