Re: [PATCH v3 23/23] untracked cache: guard and disable on system changes

From: Duy Nguyen <pclouds@gmail.com>
Date: Dec 9, 2014, 22:53 UTC
Message-ID: <CACsJy8A5-smRXN0k5TK8uPg4-j-Z83KWLNSO_w-eFivTNB_www@mail.gmail.com>
In-Reply-To: <20141209100430.GC76457@vauxhall.crustytoothpaste.net>

On Tue, Dec 9, 2014 at 5:04 PM, brian m. carlson <sandals@crustytoothpaste.net> wrote:

Show 19 quoted lines

> On Mon, Dec 08, 2014 at 09:05:07PM +0700, Nguyễn Thái Ngọc Duy wrote:
>> If the user enables untracked cache, then
>>
>>  - move worktree to an unsupported filesystem
>>  - or simply upgrade OS
>>  - or move the whole (portable) disk from one machine to another
>>  - or access a shared fs from another machine
>>
>> there's no guarantee that untracked cache can still function properly.
>> Record the worktree location and OS footprint in the cache. If it
>> changes, err on the safe side and disable the cache. The user can
>> 'update-index --untracked-cache' again to make sure all conditions are
>> met.
>
> My use case for untracked cache is where I have one machine with a
> repository and which is also mounted via sshfs on another machine.  It
> looks like this will disable the cache every time I change the machine I
> access it on.  Would you be willing to accept a patch for a configuration
> option to disable this?

Torsten also does not like this patch. Maybe I'm just too paranoid. Maybe we can drop this patch.

-- 
Duy