Re: [PATCH] Document the HTTP transport protocols

From: Duy Nguyen <pclouds@gmail.com>
Date: Aug 22, 2013, 11:27 UTC
Message-ID: <CACsJy8A4c3gFeX+q4hPjki8+mLjv_xo4tNbhyyCcmaUX7tYFLA@mail.gmail.com>
In-Reply-To: <20130821220021.GA32130@sigill.intra.peff.net>

On Thu, Aug 22, 2013 at 5:00 AM, Jeff King <peff@peff.net> wrote:

Show 12 quoted lines

> On Wed, Aug 21, 2013 at 08:45:13PM +0700, Nguyen Thai Ngoc Duy wrote:
>
>>  On the topic, C Git's (maybe) violations on this spec are:
>>
>>   - The client does not strip trailing slashes from $GIT_URL before
>>     sending to the server, as described in section "URL Format".
>
> Yeah. We get the basic gist right by not adding an extra "/" if there is
> already a trailing slash (so you do not have http://host/path//info/refs").
> But we do not go out of our way to remove multiple slashes that the user
> hands out (either at the end or in the middle of the URL). I doubt that
> it matters in practice.

It may make writing rewrite/matching patterns in http server a tiny bit harder, but should not be a big deal. I agree with Junio this could be something a new contributor can work on to get familiar with (scary, imo) transport/connect code.

I agree with the rest of your comments that those "violations" do not matter much (when I raised them I did not mean "fix Git", just checking if I missed anything) and the document is ok as-is.

-- 
Duy