Re: [PATCH] format-patch: notice failure to open cover letter for writing

From: Duy Nguyen <pclouds@gmail.com>
Date: Feb 22, 2019, 07:50 UTC
Message-ID: <CACsJy8A1cqWkomePW8i6veNT+WP2nq_kAZHay74ZgZFsz-d+nw@mail.gmail.com>
In-Reply-To: <20190222062606.GD10248@sigill.intra.peff.net>

On Fri, Feb 22, 2019 at 1:28 PM Jeff King <peff@peff.net> wrote:

Show 13 quoted lines

> > diff --git a/builtin/log.c b/builtin/log.c
> > index 3e145fe502..43fc9a07df 100644
> > --- a/builtin/log.c
> > +++ b/builtin/log.c
> > @@ -1047,7 +1047,7 @@ static void make_cover_letter(struct rev_info *rev, int use_stdout,
> >
> >       if (!use_stdout &&
> >           open_next_file(NULL, rev->numbered_files ? NULL : "cover-letter", rev, quiet))
> > -             return;
> > +             die(_("Failed to create cover-letter file"));
>
> I'd suggest s/F/f/ in the message to match our usual style, though I see
> this code has a lot of capitalized errors already. :)

Thanks! The lowercase wins over uppercase [1] 1517 to 327. Unfortunately it's a tie in this file. But I think it's still good that new messages stick to lowercase.

[1] counting error/warn/die only with

git grep 'die[_a-z]*(_("[A-Z]\|error[_a-z]*(_("[A-Z]\|warning[_a-z]*(_("[A-Z]' -- \*.c

-- 
Duy