Re: [RFC] i18n.pathencoding

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Sep 4, 2012, 12:23 UTC
Message-ID: <CACsJy8A1GnhTeMzwXwA1C96pp0ERskxZC=SO+QE2__pfwmChow@mail.gmail.com>
In-Reply-To: <201209010811.33994.tboegi@web.de>

On Sat, Sep 1, 2012 at 1:11 PM, Torsten Bögershausen <tboegi@web.de> wrote:

Show 12 quoted lines

> diff --git a/parse-options.c b/parse-options.c
> index c1c66bd..5840c18 100644
> --- a/parse-options.c
> +++ b/parse-options.c
> @@ -476,7 +476,7 @@ int parse_options(int argc, const char **argv, const char *prefix,
>                 usage_with_options(usagestr, options);
>         }
>
> -       precompose_argv(argc, argv);
> +       reencode_argv(argc, argv);
>         return parse_options_end(&ctx);
>  }

If you have to re-encode command line arguments, what about paths coming --stdin or a file? I guess that paths that are argument to an option are not re-encoded too, which may put git in an inconsistent state where it cannot compare paths to paths because some may be re-encoded above, some not.

-- 
Duy