Re: [PATCH v2 2/3] Setup working tree in describe

From: Duy Nguyen <pclouds@gmail.com>
Date: Jan 27, 2019, 00:21 UTC
Message-ID: <CACsJy8A+QsSDfL_RX2ctNsV35VpBaSp4M7hR00nSObmmULUmvg@mail.gmail.com>
In-Reply-To: <20190126204951.42455-2-koraktor@gmail.com>

On Sun, Jan 27, 2019 at 3:51 AM Sebastian Staudt <koraktor@gmail.com> wrote:

Show 5 quoted lines

>
> This ensures the given working tree is used for --dirty.
>
> The implementation of --broken uses diff-index which calls
> setup_work_tree() itself.

It would be nice to have a test case covering --broken even if no fix is needed (so that somebody else will not accidentally break it later). I did a quick test and thought it was broken, but it turns out I tested it wrong :P

Show 20 quoted lines

> Signed-off-by: Sebastian Staudt <koraktor@gmail.com>
> ---
>  builtin/describe.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/builtin/describe.c b/builtin/describe.c
> index cc118448ee..b5b7abdc8f 100644
> --- a/builtin/describe.c
> +++ b/builtin/describe.c
> @@ -629,6 +629,7 @@ int cmd_describe(int argc, const char **argv, const char *prefix)
>                         struct argv_array args = ARGV_ARRAY_INIT;
>                         int fd, result;
>
> +                       setup_work_tree();
>                         read_cache();
>                         refresh_index(&the_index, REFRESH_QUIET|REFRESH_UNMERGED,
>                                       NULL, NULL, NULL);
> --
> 2.20.1
>

-- 
Duy