Re: [PATCH/RFC] Restore line limit option in post-receive-email
- From
- Cheng Leong <leongc@alumni.rice.edu>
- Date
- Nov 11, 2011, 07:08 UTC
- Message-ID
- <CACor6wGkDPSkA_G117YtnsQA7H_cROKKW69m-jW_rb2SrVWo1w@mail.gmail.com>
- In-Reply-To
- <7v4nybrvug.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> wrote:
> Umm, there is another place where $maxlines is used without > merit. Shouldn't we do something like below as well?
...
> - generate_email $maxlines | send_mail > + generate_email | send_mail
Agree. $maxlines is harmless, but extraneous here. Would you like me to reroll a patch with both or is this a trivial fixup?
Cheng