Re: [PATCH] gc: notice gc processes run by other users
- From
Thiago Farina <tfransosi@gmail.com>
- Date
- Dec 31, 2013, 20:35 UTC
- Message-ID
- <CACnwZYe91VOX=JYOOek5UsDv4=F5wEDPj_20H5iyZKnurgXgzQ@mail.gmail.com>
- In-Reply-To
- <720d7a5676f8cbfc76c80198f9d3816@74d39fa044aa309eaea14b9f57fe79c>
On Tue, Dec 31, 2013 at 10:07 AM, Kyle J. McKay <mackyle@gmail.com> wrote:
Show 14 quoted lines
> Since 64a99eb4 git gc refuses to run without the --force option if > another gc process on the same repository is already running. > > However, if the repository is shared and user A runs git gc on the > repository and while that gc is still running user B runs git gc on > the same repository the gc process run by user A will not be noticed > and the gc run by user B will go ahead and run. > > The problem is that the kill(pid, 0) test fails with an EPERM error > since user B is not allowed to signal processes owned by user A > (unless user B is root). > > Update the test to recognize an EPERM error as meaning the process > exists and another gc should not be run (unless --force is given).
Looks like you are missing your Signed-off-by: line.
-- Thiago Farina