git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Determining if a merge was produced automatically

From
PRPavel Rappo <pavel.rappo@gmail.com>
Date
Jul 1, 2024, 16:08 UTC
Message-ID
<CAChcVu=bWR_DvR==b7L0tn8PmK+9KOWWw+e7RtjMhywMv3W+qA@mail.gmail.com>
In-Reply-To
<xmqqle2lyvdd.fsf@gitster.g>

I can see that I used "robustly" misleadingly. My intent was to get robust automation, not a robust boolean classifier; sorry.

Here's my use case. In our project, every commit to a PR means that the PR needs to be re-reviewed. During a PR's lifetime, the PR's target branch might be merged into the PR multiple times. Since re-reviewing is costly, I'm exploring the possibility of not requiring it for such merge commits produced automatically because of the assumption that nothing bad can happen there.

In that use case, both false positives and false negatives are _fine_, if only annoying. If it's false positive, meaning that a PR has been truly merged, but the check couldn't figure it out, re-review will be required. Not a big deal. If it's false negative, meaning that a PR has been tampered with, but looks like it hasn't, then it's okay. Why? Because the result will be the _same_ [^*] if that PR is eventually, automatically merged into the target branch by that very Git that performed the merge check.

[*]: Or very, very similar.
Previous: Junio C HamanoNext: Junio C Hamano
Message 6 of 11 in “Determining if a merge was produced automatically”
  1. Pavel RappoJun 30, 2024
  2. Jonathan NiederJul 1, 2024
  3. Pavel RappoJul 1, 2024
  4. Junio C HamanoJul 1, 2024
  5. Junio C HamanoJul 1, 2024
  6. Pavel RappoJul 1, 2024
  7. Junio C HamanoJul 1, 2024
  8. Pavel RappoJul 1, 2024
  9. Martin von ZweigbergkJul 1, 2024
  10. Elijah NewrenJul 1, 2024
  11. Pavel RappoJul 1, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.