Re: [PATCH v2 1/1] branch: advise the user to checkout a different branch before deleting
- From
Heba Waly <heba.waly@gmail.com>
- Date
- Jan 8, 2020, 18:06 UTC
- Message-ID
- <CACg5j260h88bd=W_4EzAn7B0TiU02Y8BzKDQ7w3UJiHkhL60NQ@mail.gmail.com>
- In-Reply-To
- <CAPig+cTDayF0hHn7wSPGNS8h2qPUYhhg9Z8fY_rLQnWmAg-NKQ@mail.gmail.com>
On Wed, Jan 8, 2020 at 10:28 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
> > advice seems simple on the surface, but every new piece of advice > means having to add yet another configuration variable, writing more > code, more tests, and more documentation
This raises a question though, do we really need a new configuration for every new advice? So a user who's not interested in receiving advice will have to disable every single advice config? It doesn't seem scalable to me. I imagine a user will either want to enable or disable the advice feature all together. Why don't we have only one `enable_advice` configuration that controls all the advice messages?
Thanks, Heba