Re: git update-ref fails to create reference. (bug)

From: Rafael Ascensão <rafa.almas@gmail.com>
Date: May 5, 2018, 19:08 UTC
Message-ID: <CACUQV5-9PagVhE5YY=Z3721YRiBwSZykT3ZjtzmD3o-c6O6ddQ@mail.gmail.com>
In-Reply-To: <20180504182646.7738-1-martin.agren@gmail.com>

Thanks Martin for the quick fix.

On Fri, May 04, 2018 at 08:26:46PM +0200, Martin �gren wrote:

Show 5 quoted lines

> Anyway, that's not where I'm stuck... Regardless of how I try to write
> tests (in t1400), they just pass beautifully even before this patch. I
> might be able to look into that more on the weekend. If anyone has
> ideas, I am all ears. Or if someone feels like picking this up and
> running with it, feel free.

In t1400 `m=refs/heads/master` is used in the majority of tests. And this issue doesn't manifest itself if refs are being written under refs/

It also seems particular about having the "old sha" set to 40 zeros or the empty string.

So I guess we should add some extra tests to cover the variations of these two cases.

e.g.
     test_expect_success "create PSEUDOREF" '
         git update-ref PSEUDOREF $A
0000000000000000000000000000000000000000 &&
         test $A = $(cat .git/PSEUDOREF)
     '

fails/succeeds appropriately in my limited testing.

I am busy this weekend, but can try to write some if no one writes it until after the weekend.

Cumprimentos, Rafael Ascensão