Re: [PATCH v3 1/9] t5520: fixup file contents comparisons
- From
Paul Tan <pyokagan@gmail.com>
- Date
- May 17, 2015, 07:47 UTC
- Message-ID
- <CACRoPnTLaJ+4Vc0Dg2rZxO2P3WUxF8++OUi24An00xNSbvTk6A@mail.gmail.com>
- In-Reply-To
- <xmqq617sfj05.fsf@gitster.dls.corp.google.com>
Hi Junio,
On Sun, May 17, 2015 at 2:57 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 16 quoted lines
> Paul Tan <pyokagan@gmail.com> writes: > >> Hi Junio, >> >> On Sat, May 16, 2015 at 2:37 AM, Junio C Hamano <gitster@pobox.com> wrote: >>> Just to avoid misunderstanding, please do not remove 'verbose ' >>> blindly without thinking while doing so, as you already did 1/3 of >>> the necessary job to make things better. >> >> Eh? I thought we established that using "verbose" does not provide >> anything more than what "set -x" already provides. So at the very >> least, its use should be removed completely. > > I did not mean "do not remove and keep them". I meant "do not > remove without thinking; instead, take mental notes on patterns > these silent ones may have while removing them".
Okay. Just to keep things moving, for now I will send a re-roll to remove "verbose" and to fix other issues like [1] and [2].
[1] http://thread.gmane.org/gmane.comp.version-control.git/268950/focus=269052 [2] http://thread.gmane.org/gmane.comp.version-control.git/268950/focus=269132
Thanks, Paul