Re: [GSoC15] Interested in contributing to git

From: Paul Tan <pyokagan@gmail.com>
Date: Mar 3, 2015, 18:08 UTC
Message-ID: <CACRoPnTAFXBRR3uv8gL8tGfYNo_ygNutJZuPm=Sq0Ae3obF-kw@mail.gmail.com>
In-Reply-To: <vpqbnkagiie.fsf@anie.imag.fr>

Hi Matthieu,

On Wed, Mar 4, 2015 at 12:20 AM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:

> Be carefull: a GSoC is a full-time job. The GSoC itself ends on August
> 21st, so there would be a substantial (too big?) overlap between the
> GSoC and your studies.

I understand. I will have to try my best to complete most of the work before then.

Show 8 quoted lines

>> I understand that I have to complete a microproject. I would like
>> complete "Move ~/.git-credentials and ~/.git-credential-cache to
>> ~/.config/git". I'm thinking that the XDG locations should take
>> precedence over the non-XDG locations?
>
> The logic is different for reading and for writting, see how Git deals
> with it for ~/.gitconfig for example. Essentially, we read both, and we
> write to the one which exists if there's only one.

I will try to implement something similar. My idea for credential-store.c is:

* For "get", lookup_credential() on the XDG file first if it exists,
and if it fails call it on the home file.
* For "remove", remove_credential() from both the xdg file and the home file.
* For "store", if the XDG file exists store_credential() in the XDG
file and remove_credential() from the home file, otherwise just
store_credential() in the home file.
* For all operations, if "--file" is provided, use it instead.

Show 7 quoted lines

> I'm the one who proposed this microproject, and some feedback on the
> mailing-list was that it was not so "micro" and probably too big
> already.
> Both for the microproject and the GSoC itself, don't be too ambitious on
> the feature you target, and don't underestimate the effort needed to get
> from "the code looks OK to me" to "the code has been reviewed on list
> and merged upstream".

Thanks, I will keep that in mind.

Also, quick question, where should the XDG tests go for git-credential-store? I see t1306-xdg-files.sh and t0302-credentials-store.sh.

Show 5 quoted lines

> Cheers,
>
> --
> Matthieu Moy
> http://www-verimag.imag.fr/~moy/

Regards, Paul