git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[BUG] Segmentation fault in git v2.41.0.rc1

From
TDTribo Dar <3bodar@gmail.com>
Date
May 24, 2023, 06:59 UTC
Message-ID
<CACJVABb8tvgXAowgtHLrC6Uau8Q03VRFu1m7K91SJwjvufqXYw@mail.gmail.com>

Running `git submodule update` after commenting out the url setting in both .gitmodules and the corresponding section for the submodule in .git/config results in a segmentation fault instead of a suitable error message.

The cause is `sub->url` being NULL here (actual segfault comes a couple calls further): https://github.com/git/git/blob/9e49351c3060e1fa6e0d2de64505b7becf157f28/builtin/submodule--helper.c#L2027

Possibly relevant: a similar snippet is being properly protected against null-pointer dereferencing here: https://github.com/git/git/blob/9e49351c3060e1fa6e0d2de64505b7becf157f28/builtin/submodule--helper.c#L1243

Next: Taylor Blau
Message 1 of 12 in “[BUG] Segmentation fault in git v2.41.0.rc1”
  1. Tribo DarMay 24, 2023
  2. Taylor BlauMay 24, 2023
  3. builtin/submodule--helper.c: handle missing submodule URLsTaylor Blau, May 24, 2023
  4. builtin/submodule--helper.c: handle missing submodule URLsTaylor Blau, May 24, 2023
  5. Eric SunshineMay 24, 2023
  6. Taylor BlauMay 24, 2023
  7. builtin/submodule--helper.c: handle missing submodule URLsTaylor Blau, May 24, 2023
  8. René ScharfeMay 24, 2023
  9. Taylor BlauMay 24, 2023
  10. Jeff KingMay 24, 2023
  11. Jeff KingMay 24, 2023
  12. Junio C HamanoMay 24, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.