Re: FORMAT_PATCH_NAME_MAX increase

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: May 30, 2017, 14:35 UTC
Message-ID: <CACBZZX7x7s-RfQMZjHuq=fbGtOeQzYin_Owqx7dK3v7dudh8zA@mail.gmail.com>
In-Reply-To: <xmqqfufmbh4f.fsf@gitster.mtv.corp.google.com>

On Tue, May 30, 2017 at 3:37 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 14 quoted lines

> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> Just curious do you know about https://github.com/trast/tbdiff ? If
>> not it might have a high overlap with what you're doing.
>
> Yes, that is a very good suggestion.  You'd need to be able to
> actually apply the patches but the way I often do a review is very
> similar to (actually, I'd say it is identical workflow) Laszlo's,
> and it goes like this:
>
>     $ git checkout topic ;# previous round
>     $ git checkout master... ;# check out the fork point of previous one
>     $ git am mbox ;# apply the updated one
>     $ git tbdiff ..@{-1} @{-1}..

I wonder if this tool seemingly everyone on-list uses should just be integrated into git.git.

I only learned about it <2 weeks ago and it's been great. The diff output was a bit nonsensical in some cases because it uses python's diff engine instead of git's.

Would you mind patches to just integrate it to git in python as-is, then we could slowly convert it to C as we're doing with everything else.