git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: "docs: stop using asciidoc no-inline-literal" breaks asciidoc 8.2.5

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
May 29, 2012, 22:42 UTC
Message-ID
<CACBZZX6a2BQVhe8-X5o+WnfbsrqPKa_Cn93GZ1bbq1TLezB97Q@mail.gmail.com>
In-Reply-To
<20120529215613.GB17598@sigill.intra.peff.net>
On Tue, May 29, 2012 at 11:56 PM, Jeff King <peff@peff.net> wrote:
Show 6 quoted lines
> I'm very sympathetic to having platform support dropped. It's annoying
> for the user. But given that it's a 3rd-party install anyway (and you
> can install a newer 3rd-party RPM), and that you can additionally use
> "make quick-install-man" to avoid needing asciidoc entirely, and given
> the sheer number of bugs this patch fixes (and prevents), to me the
> balance still argues for keeping the patch.

To be clear I like the patch, I was just suggesting that we might want to hold it off for a bit.

Anyway, I've tested dropping asciidoc.py from the source distribution into compat/asciidoc.py and doing "make doc ASCIIDOC=../compat/asciidoc.py", it seems to work.

I wonder if the easiest solution is to change the default asciidoc invocation from "asciidoc" to a small Documentation/asciidoc.sh script that we supply, it would check if there's an asciidoc present on the system, whether it's sufficiently new, and if not fall back on a copy we have in compat/.

Previous: Dennis KaarsemakerNext: Ævar Arnfjörð Bjarmason
Message 8 of 15 in “"docs: stop using asciidoc no-inline-literal" breaks asciidoc 8.2.5”
  1. Ævar Arnfjörð BjarmasonMay 29, 2012
  2. Thomas RastMay 29, 2012
  3. Ævar Arnfjörð BjarmasonMay 29, 2012
  4. Junio C HamanoMay 29, 2012
  5. Jeff KingMay 29, 2012
  6. Jeff KingMay 29, 2012
  7. Dennis KaarsemakerMay 29, 2012
  8. Ævar Arnfjörð BjarmasonMay 29, 2012
  9. Ævar Arnfjörð BjarmasonMay 29, 2012
  10. Jeff KingMay 30, 2012
  11. Matthieu MoyMay 30, 2012
  12. 0/3 docs: asciidoc version tweaksJeff King, May 30, 2012
  13. 1/3 INSTALL: update asciidoc recommendationJeff King, May 30, 2012
  14. 2/3 docs: drop asciidoc7compatible flagJeff King, May 30, 2012
  15. 3/3 docs: drop antique comment from MakefileJeff King, May 30, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.