Re: [PATCH v3 0/4] Implement git stash as a builtin command

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: May 28, 2017, 19:08 UTC
Message-ID: <CACBZZX5wA57+9t+wzYc-iMpvns-zm1XAdzKszUk7PF2vkoxeMQ@mail.gmail.com>
In-Reply-To: <20170528165642.14699-1-joel@teichroeb.net>

On Sun, May 28, 2017 at 6:56 PM, Joel Teichroeb <joel@teichroeb.net> wrote:

> I've rewritten git stash as a builtin c command. All tests pass,
> and I've added two new tests. Test coverage is around 95% with the
> only things missing coverage being error handlers.

Worth noting, with your patches the best of 3 run of all the stash tests:

$ for i in {1..3}; do (time prove -j1 t*-stash*.sh) 2>&1 | grep ^real; done |awk '{print $2}' | sort -n | head -n 1 0m3.293s

Without:

$ for i in {1..3}; do (time prove -j1 t*-stash*.sh) 2>&1 | grep ^real; done |awk '{print $2}' | sort -n | head -n 1 0m7.619s

Of course some individual invocations are much faster than that, this includes all the shell overhead of the tests themselves.