git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] tag: Implicitly supply --list given another list-like option

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Mar 12, 2017, 09:15 UTC
Message-ID
<CACBZZX52UYdGa1--wAz+beHNCMST4NoopJvFg68hLDaeaq=DNQ@mail.gmail.com>
In-Reply-To
<xmqqefy3w6k0.fsf@gitster.mtv.corp.google.com>
On Sun, Mar 12, 2017 at 3:51 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 20 quoted lines
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>>> Junio: This will merge conflict with my in-flight --no-contains
>>> patch. I can re-send either one depending on which you want to accept
>>> first, this patch will need an additional test for --no-contains. I
>>> just wanted to get this on the ML for review before the --no-contains
>>> patch hit "master".
>
> I haven't looked at the patch text of this one closely yet, but I
> think the goals of both make sense, so we would eventually want to
> have them both.
>
> I also think that "if you said --contains, --merged, etc. you are
> already asking to give you a list and cannot be creating a new one",
> which is the topic of this patch, makes sense even if nobody were
> interested in asking "--no-contains".
>
> So perhaps you would want this applied first, so that existing three
> can already benefit from "implicit --list" before waiting for the
> other one?

Yes, let's do this one first. I'll address the comments that have come up & just make this all part of one series on top of JK's patches.

Previous: Junio C HamanoNext: Junio C Hamano
Message 8 of 11 in “BUG: "git branch --contains <commit> <name>" does nothing, silently fails”
  1. Ævar Arnfjörð BjarmasonMar 10, 2017
  2. Jeff KingMar 10, 2017
  3. Ævar Arnfjörð BjarmasonMar 10, 2017
  4. tag: Implicitly supply --list given another list-like optionÆvar Arnfjörð Bjarmason, Mar 11, 2017
  5. Ævar Arnfjörð BjarmasonMar 11, 2017
  6. Junio C HamanoMar 12, 2017
  7. Junio C HamanoMar 12, 2017
  8. Ævar Arnfjörð BjarmasonMar 12, 2017
  9. Junio C HamanoMar 12, 2017
  10. Ævar Arnfjörð BjarmasonMar 12, 2017
  11. Jeff KingMar 12, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.