Re: [PATCH] t5510: skip tests under GETTEXT_POISON build

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Jul 26, 2016, 20:11 UTC
Message-ID: <CACBZZX4r5jax62oVYFsWONkyREshipGC8AFu8yfr6B7y9bMQDQ@mail.gmail.com>
In-Reply-To: <xmqq4m7c2ve8.fsf@gitster.mtv.corp.google.com>

On Tue, Jul 26, 2016 at 6:53 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 13 quoted lines

> [...] Back when 5e9637c6 (i18n: add infrastructure for
> translating Git with gettext, 2011-11-18) introduced the former,
> test_have_prereq did not support a negated prerequisite, so the
> commit added GETTEXT_POISON prerequisite; if we had the modern
> test_have_prereq, we would have written
>
>     test_expect_success GETTEXT_POISON '...'
>
> that appear in t0205 as
>
>     test_expect_success !C_LOCALE_OUTPUT '...'
>
> I would think.

Maybe the names of the test prerequisites should be merged. I can't think of a rea

As for the GETTEXT_POISON facility in general, I haven't worked much if at all on the i18n toolchain since I initially wrote the gettext support so I think at this point it's for others to say whether stuff like this is useful.

But for what it's worth the v1.7.4.1-65-gbb946bb commit explains better what it's for:

    This is a debugging aid for people who are working on the i18n part of
    the system, to make sure that they are not marking plumbing messages
    that should never be translated with _().

I.e. so the person gettext-izing something can actively spot issues with marking strings for translations right away.