git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Subscribing Apple people to git-security@googlegroups.com

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Jul 10, 2018, 12:27 UTC
Message-ID
<CACBZZX4X05EHd+OpBpLotGuY6H=pnB9dS9Rv5BONfCKjZM3a1A@mail.gmail.com>
In-Reply-To
<20180703133645.GA20316@sigill.intra.peff.net>
On Tue, Jul 3, 2018 at 3:36 PM, Jeff King <peff@peff.net> wrote:
Show 26 quoted lines
> On Mon, Jul 02, 2018 at 01:15:19PM -0700, Jeremy Huddleston Sequoia wrote:
>
>> > I hope that maybe they're also interested in reducing the overall
>> > diff between upstream Git and what ships with XCode. Last time I
>> > looked (which was admittedly a while ago), a lot of the changes
>> > seemed like things that could probably be considered upstream.
>>
>> I'm very very interested in having reduced differences between what we
>> ship in Xcode and what is upstream.  I've been maintaining a repo with
>> our patches that I rebase as we move forward, in the hope that these
>> changes might be useful to others and a derivative of them might
>> eventually be accepted upstream.  See
>> https://github.com/jeremyhu/git/commits/master for the current set of
>> changes that are in our shipping git (currently on top of 2.17.1).
>
> Thanks for sharing. Skimming over it, I see:
>
>  - several of the changes look related to run-time relocation. There was
>    a series that shipped in v2.18.0 related to this, so that may reduce
>    your diff once you rebase.
>
>  - The xcode_gitattributes() bits aren't likely to go upstream as-is.
>    But possibly these could ship as a default $sysconfdir/gitattributes?
>
>  - the rest look like assorted little fixes that probably could go
>    upstream

Jeremy, could you elaborate on what https://github.com/jeremyhu/git/commit/61b42bc5d2 was about? I.e. where was this discussed & tests for this refused?

Seems sensible to me to have this in some form, but the test as-is seems to be a general regression test, not Apple-specific, so it would need to be changed somewhat, or does it only happen with some other custom patch of yours?

Previous: Jonathan NiederNext: Jeremy Huddleston Sequoia
Message 8 of 9 in “Re: Subscribing Apple people to git-security@googlegroups.com”
  1. Jeff KingJul 2, 2018
  2. Johannes SchindelinJul 10, 2018
  3. Jeff KingJul 2, 2018
  4. Jeff KingJul 3, 2018
  5. Jonathan NiederJul 3, 2018
  6. Jeff KingJul 3, 2018
  7. Jonathan NiederJul 9, 2018
  8. Ævar Arnfjörð BjarmasonJul 10, 2018
  9. Jeremy Huddleston SequoiaJul 10, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.