Re: [PATCH] compat/regex: fix typos in comments.

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: May 6, 2012, 12:55 UTC
Message-ID: <CACBZZX4K5vh7CjJ6SqX-reuuNqse7koONC=1HcXCuY0vbXRpbQ@mail.gmail.com>
In-Reply-To: <1336308300-4858-1-git-send-email-semtlenori@gmail.com>

On Sun, May 6, 2012 at 2:45 PM, Yi, EungJun <semtlenori@gmail.com> wrote:

> From: "Yi, EungJun" <semtlenori@gmail.com>
>
> occured => occurred

In d18f76d I changed compat/regex to use the engine from gawk, there have been a few fixes of ours to it since then, some of which may be applicable for upstream inclusion:

    $ git --no-pager log --oneline --reverse d18f76d.. -- compat/regex
    a997bf4 compat/regex: get the gawk regex engine to compile within git
    de83172 Change regerror() declaration from K&R style to ANSI C (C89)
    b50f370 compat/regex: define out variables only used under RE_ENABLE_I18N
    178b331 compat/regex: get rid of old-style definition
    ce518bb Fix compat/regex ANSIfication on MinGW

But I don't think we should be taking patches like these. I think they should instead be sent to the upstream gawk developers who I'm sure would be happy to take them.

But this is not code that we're maintaining, and patches like these just make it harder to merge the code from upstream.