Re: [GSOC] Student Introduction - Reachability bitmap Improvements

From: Shubham Mishra <shivam828787@gmail.com>
Date: Feb 22, 2022, 07:47 UTC
Message-ID: <CAC316V6Y6zCT1MACHnaXbh+EEmQPz4_fLRFdK90tBsdkX2h41g@mail.gmail.com>
In-Reply-To: <YhLvdjghyC+WQI6e@nand.local>

Hi,

Thanks, I have started working on it. I have a little doubt, I can see we are using pipe with other commands too (not just git). I wanted to ask why we are only caring about error codes of "git" commands which get suppressed due to pipe. Not for other commands?

Thanks, Shuabham

On Mon, Feb 21, 2022 at 7:18 AM Taylor Blau <me@ttaylorr.com> wrote:

Show 41 quoted lines

>
> Hi Shubham,
>
> On Sun, Feb 20, 2022 at 10:39:13PM +0530, Shubham Mishra wrote:
> > Hi,
> > I am Interested in Project - "Reachability bitmap Improvements".
>
> Great! I am excited that you are interested.
>
> > I am going through the blog [1] and I love the technique we are using
> > to fasten the queries. I have still not decided which one idea to pick
> > out of many mentioned under "Reachability bitmap Improvements" but I
> > think I will figure that out soon.
>
> Let me know if you have any questions about the projects listed there,
> and I'd be happy to add some more details. Alternatively, if none of
> them pique your interest, that is OK, too, and we can brainstorm other
> potential projects.
>
> > Can someone please tell me if a micro-project - "avoid pipes in git
> > related commands in test scripts" mentioned [2] is still available to
> > take?
>
> Oh, yes. Here is a command you can run to find some of them:
>
>     $ git grep "git[^|]*|\($\|[^|]\)" -- t
>
> There are some false-positives, but that should give you a good starting
> point to look for potential spots to touch up.
>
> BTW, re-reading [2], I wanted to clarify that "The git command should be
> on the left side of a pipe" is describing what we should remove, not
> add.
>
> I'm looking forward to your patches!
>
> > [1] https://github.blog/2015-09-22-counting-objects
> > [2] https://git.github.io/SoC-2022-Microprojects/
>
> Thanks,
> Taylor