Re: [PATCH v2 0/3] line-log: integrate -L with the standard log output pipeline
- From
Michael Montalbo <mmontalbo@gmail.com>
- Date
- May 28, 2026, 19:31 UTC
- Message-ID
- <CAC2QwmJZyVY0EZnr1144gRrAxBxVoxd1x64t60DL-SeWFyn6Rw@mail.gmail.com>
- In-Reply-To
- <xmqqo6hzjrde.fsf@gitster.g>
On Thu, May 28, 2026 at 11:55 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 8 quoted lines
> > "D. Ben Knoble" <ben.knoble@gmail.com> writes: > > >> ++ ! test_grep "^diff --git" actual && > >> ++ ! test_grep "^@@" actual > > > > I wish we had docs for all the little test helpers… in particular, I > > think this is supposed to be "test_grep !" ?
Good catch, thank you! Will submit a fix and try to address the lack of docs in a follow-up.
> > Good eyes. I wonder if we teach test-lint to catch these.
I had the same thought, and started working on a series that does this and migrates existing offenders. I should be able to submit it soon.