Re: Is it not bug git stash -- <pathspec> does not work at non-root directory?

From: 小川恭史 <aiueogawa217@gmail.com>
Date: Nov 18, 2017, 04:12 UTC
Message-ID: <CAC2JkrLWVEHvV7tf24bPmVEDpgnrKTFtHR5UHMh+kC8v_fWumA@mail.gmail.com>
In-Reply-To: <xmqqzi7kp7j2.fsf@gitster.mtv.corp.google.com>

> Please make it a habit (not limited to when interacting with _this_

project) to state a bit more than "does not work"; instead, say "it is expected to do X, but instead it does Y, and the difference between X and Y I perceive is Z".

Thanks. I'll rewrite the issue.

Assuming that we have sub/something and something is not included anywhere else,

        cd sub && git stash -- something

 is expected to make a stash for sub/something but instead returns error like

        error: pathspec 'something' did not match any file(s) known to git.
        Did you forget to 'git add'?

I don't know what I should write about 'the difference between X and Y is Z'.

2017-11-18 12:53 GMT+09:00 Junio C Hamano <gitster@pobox.com>:

Show 22 quoted lines

> 小川恭史 <aiueogawa217@gmail.com> writes:
>
>> Is it not bug git stash -- <pathspec> does not work at non-root directory?
>
> Please make it a habit (not limited to when interacting with _this_
> project) to state a bit more than "does not work"; instead, say "it
> is expected to do X, but instead it does Y, and the difference
> between X and Y I perceive is Z".
>
> If you mean
>
>         cd sub && git stash -- Makefile
>
> does not make a stash for only sub/Makefile and instead makes (or
> attempts to make) a stash for only Makefile at the top-level, then
> I think it is a bug, whose likely cause is that the implementation
> forgets to prepend the $prefix to the pathspec it got from the
> command line.  But I am writing this without looking at the
> implementation and with your unclear description of the issue, so
> I may be completely off the mark ;-)
>
> Thanks.