Re: [PATCH] completion: complete --move for git branch

From: Ville Skyttä <ville.skytta@iki.fi>
Date: Jun 6, 2016, 16:19 UTC
Message-ID: <CABr9L5AK5KhFvAW4dah3Hji_VStgYKesnD+Ljari7ihJX8Y7fg@mail.gmail.com>
In-Reply-To: <582640631.360243.1465222588996.JavaMail.zimbra@ensimag.grenoble-inp.fr>

On Mon, Jun 6, 2016 at 5:16 PM, Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr> wrote:

Show 13 quoted lines

>
> Hi,
>
> Ville Skyttä <ville.skytta@iki.fi> writes:
> >          while [ $c -lt $cword ]; do
> >                  i="${words[c]}"
> >                  case "$i" in
> > -                -d|-m)        only_local_ref="y" ;;
> > -                -r)        has_r="y" ;;
> > +                -d|-m|--move)        only_local_ref="y" ;;
>
> "While you're at it" you might want to do the same thing for
> `--delete`.

I'm afraid the "while I'm at it" would never end if I start looking deeper into missing things there, so I'd prefer this self contained one I keep running into myself applied first.

> > +                -r)                has_r="y" ;;
>
> You are introducing an additional tab here that you probably didn't
> want.

It was intentionally added it to keep "only_local_ref" and "has_r" tab-aligned the way they already were.