git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Bug report: Incorrect GIT_FLUSH behavior in 2.43.1 (regression and breaking)

From
XWXiaoguang WANG <wxiaoguang@gmail.com>
Date
Feb 12, 2024, 17:18 UTC
Message-ID
<CABn0oJupUjbu2k0adFqcjryj6=XtmwQzb0vMGtYan8WccPtYxA@mail.gmail.com>
In-Reply-To
<xmqq8r3p7glr.fsf@gitster.g>
On Tue, Feb 13, 2024 at 1:11 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 7 quoted lines
> > And by the way, only accepting GIT_FLUSH=true is quite breaking, it
> > drops the compatibility of GIT_FLUSH=1
>
> I do not think so. If the polarity is corrected, git_env_bool()
> would say "that's affirmative" when any one of the "1", "true",
> "yes", "on", etc. is given.  If you have been passing "1", you
> should get the "always flush" behaviour.

Oh yes, you are right. There is a git_parse_int call in git_parse_maybe_bool, so if the "flipping" could be fixed, then everything should be fine.

Previous: Junio C HamanoNext: Phillip Wood
Message 3 of 7 in “Bug report: Incorrect GIT_FLUSH behavior in 2.43.1 (regression and breaking)”
  1. Xiaoguang WANGFeb 12, 2024
  2. Junio C HamanoFeb 12, 2024
  3. Xiaoguang WANGFeb 12, 2024
  4. Phillip WoodFeb 13, 2024
  5. Junio C HamanoFeb 13, 2024
  6. Junio C HamanoFeb 13, 2024
  7. Phillip WoodFeb 14, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.