Re: [PATCH v3] [Outreachy PATCH] t0001: avoid pipes in test scripts

From: Srujith Poojary <poojarysrujith@gmail.com>
Date: Oct 23, 2026, 16:23 UTC
Message-ID: <CABh_KWjPyBGYg7sTAg5Y7ik=qkDQJCLRHFfCiOr5O+3=mCYBPg@mail.gmail.com>
In-Reply-To: <pull.2260.v3.git.1792732388827.gitgitgadget@gmail.com>

Hi,

I have submitted v3 of the t0001 patch to the mailing list. Just a quick note on the CI: there is a single failure in win test (5), but it is caused by t1051-large-conversion running out of memory during a 5GB conversion test, which is unrelated to the t0001 changes.

The patch is ready for review.

Best regards, Srujith

On Fri, Oct 23, 2026 at 10:43 AM Srujith A Poojary via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 50 quoted lines

>
> From: Srujith Poojary <poojarysrujith@gmail.com>
>
> Avoid piping output from git version directly into sed to ensure
>
> that any command failure is properly caught by test scripts.
>
> Signed-off-by: Srujith Poojary <poojarysrujith@gmail.com>
> ---
>     [Outreachy PATCH] t0001: avoid pipes in test scripts
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2260%2Fpoojarysrujith%2Fmicroproject-init-pipe-v3
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2260/poojarysrujith/microproject-init-pipe-v3
> Pull-Request: https://github.com/gitgitgadget/git/pull/2260
>
> Range-diff vs v2:
>
>  1:  7d118290ce ! 1:  a70ccdf49e [Outreachy PATCH] t0001: avoid pipes in test scripts
>      @@ t/t0001-init.sh: test_expect_success 'default ref format' '
>         ) &&
>       - git version --build-options | sed -ne "s/^default-ref-storage-format: //p" >expect &&
>       + git version --build-options >build-options &&
>      -+         sed -ne "s/^default-ref-storage-format: //p" build-options >expect &&
>      ++ sed -ne "s/^default-ref-storage-format: //p" build-options >expect &&
>         git -C refformat rev-parse --show-ref-storage-format >actual &&
>         test_cmp expect actual
>        '
>
>
>  t/t0001-init.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/t/t0001-init.sh b/t/t0001-init.sh
> index f1d227f271..c8c74f681b 100755
> --- a/t/t0001-init.sh
> +++ b/t/t0001-init.sh
> @@ -678,7 +678,8 @@ test_expect_success 'default ref format' '
>                 sane_unset GIT_DEFAULT_REF_STORAGE_FORMAT &&
>                 git init refformat
>         ) &&
> -       git version --build-options | sed -ne "s/^default-ref-storage-format: //p" >expect &&
> +       git version --build-options >build-options &&
> +       sed -ne "s/^default-ref-storage-format: //p" build-options >expect &&
>         git -C refformat rev-parse --show-ref-storage-format >actual &&
>         test_cmp expect actual
>  '
>
> base-commit: 6de20f6092dcf9bdb1c8efe03db4b70c82b423dd
> --
> gitgitgadget