Bug report: 'filtering content' delayed progress message does not respect --quiet
- From
Sean Allred <allred.sean@gmail.com>
- Date
- Mar 21, 2021, 20:53 UTC
- Message-ID
- <CABceR4ZFVW=zeSwef7_dP+TWZ29J7BUkmMEB1CzCz=et_yYS9w@mail.gmail.com>
Hi folks,
Submitting the filled-out template from git-bugreport. Let me know if I can be of any assistance.
Thanks! -Sean
Thank you for filling out a Git bug report! Please answer the following questions to help us understand your issue.
What did you do before the bug happened? (Steps to reproduce your issue)
Called `git clone --quiet git://path/to/private/repo`
What did you expect to happen? (Expected behavior)
Expected git to be quiet :-) Did not expect writes to stderr/stdout.
What happened instead? (Actual behavior)
Received output that looked like
Filtering content: --% (--/--), --.-- MiB | --.-- MiB/s
What's different between what you expected and what actually happened?
`--quiet` should suppress all output, but in actuality, that line was still output.
Anything else you want to add:
Submitting from https://github.com/git-lfs/git-lfs/issues/1270 (re https://github.com/git-lfs/git-lfs/issues/1270#issuecomment-461176647). Other details may be available there.
I've verified I can still reproduce on the current version of git (listed below) with a private repo (note to self: gid://gitlab/Project/2458).
It looks like we need similar handling from index_pack.c:resolve_deltas at entry.c:finish_delayed_checkout. It looks like the necessary state may not be available where it's needed, but this is based on about two minutes of reading :-)
Please review the rest of the bug report below. You can delete any lines you don't wish to share.
[System Info] git version: git version 2.31.0.windows.1 cpu: x86_64 built from commit: 959b2f0c6fb12f8ba13f9015c4482fa8133b7f9c sizeof-long: 4 sizeof-size_t: 8 shell-path: /bin/sh feature: fsmonitor--daemon uname: Windows 10.0 17763 compiler info: gnuc: 10.2 libc info: no libc information available $SHELL (typically, interactive shell): <unset>
[Enabled Hooks] not run from a git repository - no hooks to show
-- -Sean