Re: [PATCH 2/2] diffcore-pickaxe doc: document -S and -G properly

From: Phil Hord <phil.hord@gmail.com>
Date: May 24, 2013, 14:58 UTC
Message-ID: <CABURp0qCOMJnQ=+p81eXLtj6+zujO=MsYODx8zR_cXjVXwV=HA@mail.gmail.com>
In-Reply-To: <CALkWK0n+NTnO0_4jNuR3Z5qmA_=-Dux+gq8kNzAT4YLC12Z8uQ@mail.gmail.com>

On Fri, May 24, 2013 at 5:37 AM, Ramkumar Ramachandra <artagnon@gmail.com> wrote:

Show 16 quoted lines

> Junio C Hamano wrote:
>> [...]
>
> I agree with the other comments, and have made suitable changes.
> Let's review your block now.
>
>>         This transformation is used to find filepairs that represent
>>         two kinds of changes, and is controlled by the -S, -G and
>>         --pickaxe-all options.
>
> Why do you call this a "transformation"?  Is git log --author="foo" a
> transformation on the git-log output?  Then how is git log -Sfoo a
> transformation?
>
> Two kinds of changes controlled by three different options?  Isn't the
> original much clearer?

They are all three filters. They transform the output by limiting it to commits which meet specific conditions. Transformation is used in the network-graphs sense of the word. It fits the beginning of the document where it says this:

  The diffcore mechanism is fed a list of such comparison results
  (each of which is called "filepair", although at this point each
  of them talks about a single file), and transforms such a list
  into another list.  There are currently 5 such transformations:

  - diffcore-break
  - diffcore-rename
  - diffcore-merge-broken
  - diffcore-pickaxe
  - diffcore-order