git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Sparse Checkout Trouble (2.5.0)

From
Elijah Newren <newren@gmail.com>
Date
Jan 28, 2020, 05:21 UTC
Message-ID
<CABPp-BHRAA71LmfYb61N+qAgwhtii7TSEVJksiAGnnO-4bk2dQ@mail.gmail.com>
In-Reply-To
<de300697-baba-62a6-ea4c-c5bd472954c2@gmail.com>
On Sun, Jan 26, 2020 at 6:09 AM Derrick Stolee <stolee@gmail.com> wrote:
Show 14 quoted lines
>
> On 1/25/2020 3:59 PM, Elijah Newren wrote:
> > On Fri, Jan 24, 2020 at 7:41 AM Derrick Stolee <stolee@gmail.com> wrote:
> >> I'm CC'ing Elijah because he also made changes to dir.c, and
> >> perhaps he has some idea of what's going on.
> >
> > If you think it might be related to the dir.c changes, I can take a
> > look.  I don't have any immediate ideas off the top of my head.
>
> The only thing I can think of is that these paths are already
> marked as sparse, but something is requiring us to test if the
> path can be created with the filesystem. I'll try to debug
> more into exactly where that is. It's telling that this happens
> both in cone mode and without.

Yeah, I'll take a look. The exponentially slow 'status --ignored' report is forcing me to look at dir.c again anyway, though it's also delaying me from getting a chance to look at this particular report.

Show 11 quoted lines
> > However, since I'm really suffering with "git read-tree -mu HEAD"
> > being the mechanism for updating sparsity (for reasons independent of
> > the issue being discussed here), I've been tempted to dig into that
> > anyway to write a replacement without the nasty side-effects.  I'll
> > take a look early next week and see if I can spot anything.
>
> If by "nasty side-effects" you mean "overwrites staged changes, even
> if in the sparse set before and after" then I would welcome such a
> change. Otherwise, it will fall to me, and this is far outside of
> my expertise. Of course, it is something I should learn, but I can
> learn that during code review, too. ;)

Yep, that's exactly what I mean. It'd be nice if Duy were still around to bug, but I've touched unpack-trees a few times so I might be able to find my way around. I'll try to take a stab at it.

> Thanks,
> -Stolee
Previous: Derrick StoleeNext: Derrick Stolee
Message 7 of 11 in “Sparse Checkout Trouble (2.5.0)”
  1. JunkYardMail1Jan 22, 2020
  2. Derrick StoleeJan 22, 2020
  3. JunkYardMail1Jan 22, 2020
  4. Derrick StoleeJan 24, 2020
  5. Elijah NewrenJan 25, 2020
  6. Derrick StoleeJan 26, 2020
  7. Elijah NewrenJan 28, 2020
  8. Derrick StoleeJan 28, 2020
  9. Johannes SchindelinJan 29, 2020
  10. Derrick StoleeJan 29, 2020
  11. Derrick StoleeJan 29, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.