Re: [PATCH 09/23] config.c: mark more strings for translation

From: Elijah Newren <newren@gmail.com>
Date: Jul 1, 2018, 05:38 UTC
Message-ID: <CABPp-BHQSTxe4=adMSo9Arg0QT7-U_SjsU-AgO42cHiMgUxPog@mail.gmail.com>
In-Reply-To: <20180630090818.28937-10-pclouds@gmail.com>

On Sat, Jun 30, 2018 at 2:08 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:

Show 14 quoted lines

> @@ -1409,11 +1409,11 @@ static int git_default_push_config(const char *var, const char *value)
>                         push_default = PUSH_DEFAULT_UPSTREAM;
>                 else if (!strcmp(value, "current"))
>                         push_default = PUSH_DEFAULT_CURRENT;
> -               else {
> -                       error("malformed value for %s: %s", var, value);
> -                       return error("Must be one of nothing, matching, simple, "
> -                                    "upstream or current.");
> -               }
> +               else
> +                       return error(_("malformed value for %s: %s\n"
> +                                      "Must be one of nothing, matching, simple, "
> +                                      "upstream or current."),
> +                                    var, value);

Patch 1?

No other issues noticed.