git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: make test Unexpected passes

From
Elijah Newren <newren@gmail.com>
Date
Apr 27, 2016, 22:39 UTC
Message-ID
<CABPp-BHFQCmu_xGNXaKAC=PjQ5+QCS9etbNSoQ3PCDHptzRWQA@mail.gmail.com>
In-Reply-To
<xmqqoa8u7lmi.fsf@gitster.mtv.corp.google.com>
On Wed, Apr 27, 2016 at 3:05 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 6 quoted lines
> Isn't what the test expects bogus in the first place?  I'd suggest
> removing the test as "pointless waste of resource".
>
> Comments?
>
> -- >8 --
Yes, toss it; I find your arguments below compelling.
Show 16 quoted lines
> Manual merge resolution by users fundamentally depends on being able
> to tell what is the tracked contents and what is the separator lines
> added by "git merge" to tell users which block of lines came from
> where.  You can deliberately craft a file with lines that resemble
> conflict marker lines to make it impossible for the user (here, the
> outer merge of merge-recursive also counts as a user of the internal
> merge) to tell which part is which, and write a test to demonstrate
> that with such a file that "git merge" fundamentally cannot work
> with and has to fail on.  It however is pointless and waste of time
> and resource to run such a test that asserts the obvious.
>
> In real life, people who do need to track files with such lines that
> have <<<< ==== >>>> as their prefixes set the conflict-marker-size
> attribute to make sure they will be able to tell between the tracked
> lines that happen to begin with these (confusing) prefixes and the
> marker lines that are added by "git merge".
Previous: Junio C HamanoNext: Ben Woosley
Message 4 of 6 in “make test Unexpected passes”
  1. Ramsay JonesApr 22, 2016
  2. Elijah NewrenApr 22, 2016
  3. Junio C HamanoApr 27, 2016
  4. Elijah NewrenApr 27, 2016
  5. Ben WoosleyApr 22, 2016
  6. Junio C HamanoApr 24, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.