git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] pull: don't say that merge is "the default strategy"

From
Elijah Newren <newren@gmail.com>
Date
Nov 19, 2021, 05:41 UTC
Message-ID
<CABPp-BHAqhpK4F2wTRhxZ5DXKOJExMxihbdpx1d2fYqAgtzS9w@mail.gmail.com>
In-Reply-To
<CAMMLpeSuL2k2semwS+K1jxTNZEV79GzCymFZo+1VcsyU6bYTrg@mail.gmail.com>
On Thu, Nov 18, 2021 at 1:40 PM Alex Henrie <alexhenrie24@gmail.com> wrote:
Show 37 quoted lines
>
> On Thu, Nov 18, 2021 at 2:30 PM Junio C Hamano <gitster@pobox.com> wrote:
> >
> > Alex Henrie <alexhenrie24@gmail.com> writes:
> >
> > > Git no longer has a default strategy for reconciling divergent branches,
> > > because there's no way for Git to know which strategy is appropriate in
> > > any particular situation.
> >
> > A very good observation, and the patch makes sense.
>
> Thanks, I'm glad you agree.
>
> > > The initially proposed version of commit
> > > 031e2f7ae195069d00d21cde906fce5b0318dbdd, "pull: abort by default when
> > > fast-forwarding is not possible", dropped this phrase from the message.
> > > It appears that leaving it in the message in the final version of the
> > > patch was accidental.
> >
> > Hmph, the one before later iterations v$N, i.e.
> >
> > https://lore.kernel.org/git/dca0455898a838b46546a29ee79f0a8b112fbff5.1626536508.git.gitgitgadget@gmail.com/
> >
> > seems to keep "the default" label from the beginning.
>
> I was referring to the patch that I originally wrote, before Elijah
> made the changes that actually got the patch accepted:
> https://lore.kernel.org/git/20210627000855.530985-1-alexhenrie24@gmail.com/
>
> > I am tempted to drop this latter last paragraph, which looks more
> > like a guess than anything else, and does not add much value to
> > future readers of the "git log".
>
> That's fine by me. I almost didn't include the second paragraph in the
> commit message to begin with.
>
> -Alex

Sorry for missing that bit from your original patch; thanks for catching it and sending in the update.

Previous: Alex HenrieNext: Junio C Hamano
Message 4 of 5 in “pull: don't say that merge is "the default strategy"”
  1. pull: don't say that merge is "the default strategy"Alex Henrie, Nov 18, 2021
  2. Junio C HamanoNov 18, 2021
  3. Alex HenrieNov 18, 2021
  4. Elijah NewrenNov 19, 2021
  5. Junio C HamanoNov 19, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.