Re: [Patch 1/3] connect.c: add nonstopssh variant to the sshVariant set.

From: Elijah Newren <newren@gmail.com>
Date: Apr 30, 2021, 16:25 UTC
Message-ID: <CABPp-BH6RgiMwGLz31nHmis3VTpuEUG--G_6Y+Wfwg24u4Zbag@mail.gmail.com>
In-Reply-To: <011f01d73dd0$ecf91e00$c6eb5a00$@nexbridge.com>

On Fri, Apr 30, 2021 at 7:58 AM Randall S. Becker <rsbecker@nexbridge.com> wrote:

Show 11 quoted lines

>
> From ba4beb8ed0dff67ae6b95692d346adce346e2871 Mon Sep 17 00:00:00 2001
> From: "Randall S. Becker" <rsbecker@nexbridge.com>
> Date: Fri, 30 Apr 2021 09:56:09 -0400
> Subject: [Patch 1/3] connect.c: add nonstopssh variant to the sshVariant set.
>
> This enhancement allows the NonStop SSH subsystem to be supported by
> git without the need of a wrapper script. The command arguments for
> the platform SSH client in /G/system/zssh/sshoss are constructed based
> on optional supplied environment variables SSH2_PROCESS_NAME (system
> defined), SSH_SUPPRESS_QUIET, and SSH_SUPPRESS_BANNER.

Before introducing 3 new special environment variables, I think this commit message should explain why you can't just use

GIT_SSH_COMMAND="/G/system/zssh/sshoss -Z -Q -S"

particularly since GIT_SSH_COMMAND was introduced specifically so people wouldn't have to create wrapper scripts to pass to GIT_SSH.