Re: A summary of in-flight topics

From: Elijah Newren <newren@gmail.com>
Date: Jan 25, 2023, 16:05 UTC
Message-ID: <CABPp-BH0LwHvN_bXp0BpekQ+f+15KNXQRzf5LCn3_BhcPzB-3A@mail.gmail.com>
In-Reply-To: <xmqq7cxbftvu.fsf@gitster.g>

On Tue, Jan 24, 2023 at 2:37 PM Junio C Hamano <gitster@pobox.com> wrote: [...]

>  - ab/sequencer-unleak                                          01-18          #8

Perhaps move to "Expecting a hopefully minor and final reroll"? See e.g. https://lore.kernel.org/git/xmqqedry17r4.fsf@gitster.g/ where you commented on Phillip's approving the code changes but wanting a number of commit message cleanups and fixes. Ævar did send a v3, and Phillip commented on two of those patches, suggesting one could still use some commit message cleanups.

>  - ab/various-leak-fixes                                        01-18         #19

Isn't this already merged as 9ea1378d04 ("Merge branch 'ab/various-leak-fixes'", 2022-12-14) ? Why does it appear under "needing review"? (I started reviewing, and while looking at the existing code noted it already had the relevant changes, then went digging and found it was merged...)

> Will merge to 'master'.
>  + en/rebase-update-refs-needs-merge-backend                    01-22/01-23    #9

I sent out a v5 since you sent this email, to include some final changes Phillip was suggesting. He seems happy with those (https://lore.kernel.org/git/94deff87-a4a0-e937-7549-3e5348361a12@dunelm.org.uk/), so I agree it can merge down, but please use v5 instead of v4.

> Will merge to 'next'?
>  - en/ls-files-doc-update                                       01-13          #4

I'm in favor, but self votes don't count so...