Re: [PATCH v2 0/6] Document 'AUTO_MERGE' and more special refs
- From
Elijah Newren <newren@gmail.com>
- Date
- Jun 1, 2023, 06:18 UTC
- Message-ID
- <CABPp-BH+vT_dEKUwn1M2D-FuCtF=hRM8OAFj9m1x6rkV97oEDA@mail.gmail.com>
- In-Reply-To
- <pull.1515.v2.git.1684783741.gitgitgadget@gmail.com>
On Mon, May 22, 2023 at 12:29 PM Philippe Blain via GitGitGadget <gitgitgadget@gmail.com> wrote:
Show 13 quoted lines
> > Thanks everyone for the review! > > Changes since v1: > > * Addressed typos and wording suggestions from Elijah > * Incoporated Eric's wording suggestion > * Added a preliminary patch adressing Victoria's suggestion, based on the > what Taylor sent. > > This version is not a "fixups on top", it's a complete new version. I don't > see the point of merging typos to master if we can instead wait for 'next' > to be rebuilt after the upcoming release.
I re-read the whole series. It addresses all the things I brought up in v1 (except the bonus idea I threw out there about mentioning how AUTO_MERGE is related to --remerge-diff), and all the things I remember others bringing up as well.
Reviewed-by: Elijah Newren <newren@gmail.com>
Thanks for working on this!