Re: [PATCH v3 00/11] Spring cleanup of "contrib/"

From: Elijah Newren <newren@gmail.com>
Date: May 13, 2025, 02:53 UTC
Message-ID: <CABPp-BGvhtoN-NYZFrodxtBZppuHtujo93=dKjdxOHHiiAr7tw@mail.gmail.com>
In-Reply-To: <20250512-pks-contrib-spring-cleanup-v3-0-32e151b0bfb0@pks.im>

On Mon, May 12, 2025 at 2:20 AM Patrick Steinhardt <ps@pks.im> wrote:

Show 18 quoted lines

>
> Hi,
>
> as I have lamented multiple times multiple times already (e.g. [1]), the
> "contrib/" directory is a bit of a mess containing many bits and pieces
> that just sit there gathering dust, without getting any maintenance and
> sometimes even in a clearly-broken state. So I decided to finally bite
> the bullet and do a spring cleanup of "contrib/", which resulted in this
> patch series here.
>
> I have used the following reasons for removal:
>
>   - The tool is clearly broken, e.g. it doesn't even compile.
>
>   - The tool has a clear alternative or just isn't useful anymore.
>
>   - The tool has already been removed, but we still carry a stub.
>

[...]

Show 8 quoted lines

> Changes in v3:
>   - Adapt the cover letter as well as commit 4 to clarify that a script
>     not receiving any updates is only used as supporting evidence, not
>     as a standalone reason to remove them.
>   - Don't remove "contrib/stats/packinfo.pl". We don't have a
>     replacement for it, and its functionality is useful. We should
>     probably add this functionality into git-verify-pack(1) itself.
>   - Link to v2: https://lore.kernel.org/r/20250509-pks-contrib-spring-cleanup-v2-0-14e20d95ec68@pks.im

Thanks, this version looks good to me.