Re: Question relate to collaboration on git monorepo

From: Elijah Newren <newren@gmail.com>
Date: Sep 23, 2022, 02:08 UTC
Message-ID: <CABPp-BGspmm7FTdGcMwX+PwfEs+XeqDWG09Tfju-p6Ea9tneFA@mail.gmail.com>
In-Reply-To: <CAJoAoZ=yc+UA7G0MBpJYVCQ6symMQwPnpfK8Wd=sf6ebB1XOhA@mail.gmail.com>

On Thu, Sep 22, 2022 at 8:21 AM Emily Shaffer <emilyshaffer@google.com> wrote:

Show 5 quoted lines

>
> On Thu, Sep 22, 2022 at 7:24 AM Derrick Stolee <derrickstolee@github.com> wrote:
> >
> > On 9/21/2022 7:36 PM, Elijah Newren wrote:
> > > On Wed, Sep 21, 2022 at 8:22 AM ZheNing Hu <adlternative@gmail.com> wrote:

[...]

Show 9 quoted lines

> > > If you add --no-stat to your merge command (or set merge.stat to
> > > false), the extra blob will not be downloaded.
> >
> > This is an interesting find! I wonder how many people are hitting this
> > in the wild. Perhaps merge.stat should be added to the optional, but
> > recommended config options in scalar.c.
>
> Yeah, that's a weird one. I wonder whether the partial clone filter
> setting should also imply a config shutting off diffstats?

Yeah, ZheNing hit on an interesting case here, and their very careful problem description with full testcases helped immensely in finding the issue. I didn't spot it at first from the output, but being able to run his examples made it relatively easy to track down -- and then I noticed I could have figured out the same information from his output if I had known to look. Even if I didn't notice the output the first time around, having the problem be discoverable from his program output certainly made it easier to describe and explain the issue. :-)