Re: [PATCH 3/7] merge-ort: add pool_alloc, pool_calloc, and pool_strndup wrappers
- From
Elijah Newren <newren@gmail.com>
- Date
- Jul 28, 2021, 22:49 UTC
- Message-ID
- <CABPp-BGjrKWXn2ZzeJ-nsZTwsDE=gbaX=1YKfiNtC70VeN9VVA@mail.gmail.com>
- In-Reply-To
- <bc24ea9c-178c-bcc9-2097-2271df93ae76@gmail.com>
On Mon, Jul 26, 2021 at 8:36 AM Derrick Stolee <stolee@gmail.com> wrote:
Show 16 quoted lines
> > On 7/23/2021 8:54 AM, Elijah Newren via GitGitGadget wrote: > > From: Elijah Newren <newren@gmail.com> > > > > We need functions which will either call > > xmalloc, xcalloc, xstrndup > > or > > mem_pool_alloc, mem_pool_calloc, mem_pool_strndup > > depending on whether we have a non-NULL memory pool. Add these > > functions; the next commit will make use of these. > > I briefly considered that this should just be the way the > mem_pool_* methods work. It does rely on the caller knowing > to free() the allocated memory when their pool is NULL, so > perhaps such a universal change might be too much. What do > you think?
That's interesting, but I'm worried it might be a bit much. Do others on the list have an opinion here?