Re: [PATCH] doc: add missing commit C to the graph for --ancestry-path=H D..M

From: Elijah Newren <newren@gmail.com>
Date: Mar 16, 2025, 06:53 UTC
Message-ID: <CABPp-BGbyKPmx=jNFE9TpvhSO0DcvqA8AETAYRt35_dG20rABQ@mail.gmail.com>
In-Reply-To: <pull.1883.git.1742089659610.gitgitgadget@gmail.com>

On Sat, Mar 15, 2025 at 6:47 PM Han Jiang via GitGitGadget <gitgitgadget@gmail.com> wrote:

>
> From: Han Jiang <jhcarl0814@gmail.com>
>
> The graph for `--ancestry-path=H D..M` should contain commit C.

Yep, C is in the range D..M and C is also an ancestor of H.

Show 5 quoted lines

> Signed-off-by: Han Jiang <jhcarl0814@gmail.com>
> ---
>     doc: add missing commit C to the graph for --ancestry-path=H D..M
>
>     cc:Elijah Newren newren@gmail.com,D. Ben Knoble ben.knoble@gmail.com

In the future, you'll probably want to use separate cc lines for each person you are cc'ing; I think gitgitgadget expects that to work. You also might want to add a space after the "cc:", though I don't know if that's required.

Show 24 quoted lines

> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1883%2Fjhcarl0814%2Fpatch_ancestry_path_doc_graph_20250315-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1883/jhcarl0814/patch_ancestry_path_doc_graph_20250315-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/1883
>
>  Documentation/rev-list-options.adoc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/rev-list-options.adoc b/Documentation/rev-list-options.adoc
> index 785c0786e0c..5e5cedb9127 100644
> --- a/Documentation/rev-list-options.adoc
> +++ b/Documentation/rev-list-options.adoc
> @@ -640,7 +640,7 @@ commits affected by that topic, we may only want to view the subset of
>  -----------------------------------------------------------------------
>                 E
>                  \
> -                 G---H---I---J
> +             C---G---H---I---J
>                                \
>                                 L--M
>  -----------------------------------------------------------------------
>
> base-commit: 683c54c999c301c2cd6f715c411407c413b1d84e
> --
> gitgitgadget

Patch looks good.