git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] parse-options.h: use designated initializers in OPT_* macros

From
Elijah Newren <newren@gmail.com>
Date
Mar 20, 2023, 16:53 UTC
Message-ID
<CABPp-BGXuQEef1Z2fDeHNJi=RSiTK1Jp1PehCtFvT1nzvJmoYw@mail.gmail.com>
In-Reply-To
<20230319165648.656738-1-szeder.dev@gmail.com>
On Sun, Mar 19, 2023 at 10:06 AM SZEDER Gábor <szeder.dev@gmail.com> wrote:
>
> Use designated initializers in the expansions of the OPT_* macros to
> make it more readable which one-letter macro parameter initializes
> which field in the resulting 'struct option'.

This series makes the code easier for me to read; thanks for submitting them. The series is pretty short and easy to read, and I couldn't find any issues anywhere.

Reviewed-by: Elijah Newren <newren@gmail.com>
Previous: SZEDER Gábor
Message 6 of 6 in “parse-options.h: use designated initializers in OPT_* macros”
  1. 0/3 parse-options.h: use designated initializers in OPT_* macrosSZEDER Gábor, Mar 19, 2023
  2. 1/3 parse-options.h: use consistent name for the callback parametersSZEDER Gábor, Mar 19, 2023
  3. 2/3 parse-options.h: rename _OPT_CONTAINS_OR_WITH()'s parametersSZEDER Gábor, Mar 19, 2023
  4. Junio C HamanoMar 20, 2023
  5. 3/3 parse-options.h: use designated initializers in OPT_* macrosSZEDER Gábor, Mar 19, 2023
  6. Elijah NewrenMar 20, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.