Re: [PATCH 10/10] Update error message and code comment
- From
Elijah Newren <newren@gmail.com>
- Date
- Aug 3, 2021, 23:49 UTC
- Message-ID
- <CABPp-BG7tRqPo2pz4ab0LNB3pWT0hZ=PpqC1u-MZKU-_LdUvjw@mail.gmail.com>
- In-Reply-To
- <nycvar.QRO.7.76.6.2108040104150.55@tvgsbejvaqbjf.bet>
On Tue, Aug 3, 2021 at 5:05 PM Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 31 quoted lines
>
> Hi Elijah,
>
> On Tue, 3 Aug 2021, Elijah Newren via GitGitGadget wrote:
>
> > From: Elijah Newren <newren@gmail.com>
> >
> > There were two locations in the code that referred to 'merge-recursive'
> > but which were also applicable to 'merge-ort'. Update them to more
> > general wording.
> >
> > Signed-off-by: Elijah Newren <newren@gmail.com>
> > ---
> > builtin/merge.c | 2 +-
> > sequencer.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/builtin/merge.c b/builtin/merge.c
> > index a8a843b1f54..24b62a9c532 100644
> > --- a/builtin/merge.c
> > +++ b/builtin/merge.c
> > @@ -738,7 +738,7 @@ static int try_merge_strategy(const char *strategy, struct commit_list *common,
> >
> > for (x = 0; x < xopts_nr; x++)
> > if (parse_merge_opt(&o, xopts[x]))
> > - die(_("Unknown option for merge-recursive: -X%s"), xopts[x]);
> > + die(_("Unknown strategy option: -X%s"), xopts[x]);
>
> Since we updated our rules to start `die()` messages with a lower-case
> letter, we could sneak in this change here, too. That would save
> translators one extra round.Sure, will do.