en/header-split-cache-h-part-2 (Was: Re: What's cooking in git.git (Apr 2023, #09; Fri, 28))
- From
Elijah Newren <newren@gmail.com>
- Date
- Apr 30, 2023, 06:58 UTC
- Message-ID
- <CABPp-BG7K0L11YGYmo504GK4mexFnBZPuDHhqSwqaD2nGwWfWQ@mail.gmail.com>
- In-Reply-To
- <xmqqzg6r9o14.fsf@gitster.g>
On Sat, Apr 29, 2023 at 12:20 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 27 quoted lines
> > * en/header-split-cache-h-part-2 (2023-04-24) 22 commits > - reftable: ensure git-compat-util.h is the first (indirect) include > - diff.h: reduce unnecessary includes > - object-store.h: reduce unnecessary includes > - commit.h: reduce unnecessary includes > - fsmonitor: reduce includes of cache.h > - cache.h: remove unnecessary headers > - treewide: remove cache.h inclusion due to previous changes > - cache,tree: move basic name compare functions from read-cache to tree > - cache,tree: move cmp_cache_name_compare from tree.[ch] to read-cache.c > - hash-ll.h: split out of hash.h to remove dependency on repository.h > - tree-diff.c: move S_DIFFTREE_IFXMIN_NEQ define from cache.h > - dir.h: move DTYPE defines from cache.h > - versioncmp.h: move declarations for versioncmp.c functions from cache.h > - ws.h: move declarations for ws.c functions from cache.h > - match-trees.h: move declarations for match-trees.c functions from cache.h > - pkt-line.h: move declarations for pkt-line.c functions from cache.h > - base85.h: move declarations for base85.c functions from cache.h > - copy.h: move declarations for copy.c functions from cache.h > - server-info.h: move declarations for server-info.c functions from cache.h > - packfile.h: move pack_window and pack_entry from cache.h > - symlinks.h: move declarations for symlinks.c functions from cache.h > - treewide: be explicit about dependence on strbuf.h > > More header clean-up. > source: <pull.1517.v2.git.1682194649.gitgitgadget@gmail.com>
Both Stolee[1] and Glen[2] have acked and think it's good.
Also, when others at the weekly libification sync asked if it needed more review, I told them that those two were probably sufficient and I suspected you'd merge the series to next soon-ish, so they didn't need to worry about it. If I was wrong about that, and you'd like to see more review, let me know.
[1] https://lore.kernel.org/git/1393c57f-9f3f-18da-8f02-badfdc62f02d@github.com/ [2] https://lore.kernel.org/git/kl6lbkjao7fe.fsf@chooglen-macbookpro.roam.corp.google.com/