Re: [PATCH 0/8] Cleanups around index operations

From: Elijah Newren <newren@gmail.com>
Date: Dec 30, 2020, 20:19 UTC
Message-ID: <CABPp-BG6iiQ=_SvGEFCGnYe+z57op+b6vWfJmw=w_0eikzpvCA@mail.gmail.com>
In-Reply-To: <pull.829.git.1609356413.gitgitgadget@gmail.com>

On Wed, Dec 30, 2020 at 11:26 AM Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 12 quoted lines

>
> I've taken a professional interest in the index lately, and I've been trying
> mostly to learn about it and measure different operations. Along the way,
> I've seen some possible improvements in documentation, behavior, and
> tracing.
>
> This series collects most of my thoughts so far, including:
>
>  1. Adding extra trace2 regions and statistics (similar to [1]) (Patches
>     1-5).
>  2. Update documentation about the cached tree extension (Patches 6-7).
>  3. Removing an unnecessary loop from verify_cache() (Patch 8).

The series seems pretty simple and clean to me. As I mentioned on patch 6, though, I don't know much about the cache-tree extension myself (I show up in blame/log due to moving a function there with just some slight tweaks), so it'd be nice if someone who does can take a look at the documentation added in patch 6.