git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] merge-ort unused parameter cleanups

From
Elijah Newren <newren@gmail.com>
Date
Sep 16, 2023, 02:56 UTC
Message-ID
<CABPp-BFzAX3b_Dm+fVcuNSKw2=7U3x747Ws7RMyWPxQ3GTNvzw@mail.gmail.com>
In-Reply-To
<20230914093409.GA2254811@coredump.intra.peff.net>
On Thu, Sep 14, 2023 at 2:34 AM Jeff King <peff@peff.net> wrote:
Show 15 quoted lines
>
> A few small cleanups for merge-ort collected from playing with
> -Wunused-parameter. The first one actually fixes a user-visible bug, and
> the rest are just cleanups.
>
>   [1/4]: merge-ort: drop custom err() function
>   [2/4]: merge-ort: stop passing "opt" to read_oid_strbuf()
>   [3/4]: merge-ort: drop unused parameters from detect_and_process_renames()
>   [4/4]: merge-ort: drop unused "opt" parameter from merge_check_renames_reusable()
>
>  merge-ort.c           | 48 +++++++++++--------------------------------
>  t/t6406-merge-attr.sh |  3 ++-
>  2 files changed, 14 insertions(+), 37 deletions(-)
>
> -Peff
All look good; thanks.
Previous: Jeff KingNext: Jeff King
Message 11 of 15 in “merge-ort unused parameter cleanups”
  1. 0/4 merge-ort unused parameter cleanupsJeff King, Sep 14, 2023
  2. 1/4 merge-ort: drop custom err() functionJeff King, Sep 14, 2023
  3. Elijah NewrenSep 16, 2023
  4. Jeff KingSep 16, 2023
  5. 2/4 merge-ort: stop passing "opt" to read_oid_strbuf()Jeff King, Sep 14, 2023
  6. 3/4 merge-ort: drop unused parameters from detect_and_process_renames()Jeff King, Sep 14, 2023
  7. Elijah NewrenSep 16, 2023
  8. 4/4 merge-ort: drop unused "opt" parameter from merge_check_renames_reusable()Jeff King, Sep 14, 2023
  9. Elijah NewrenSep 16, 2023
  10. Jeff KingSep 16, 2023
  11. Elijah NewrenSep 16, 2023
  12. 5/4 merge-ort: lowercase a few error messagesJeff King, Sep 16, 2023
  13. Jeff KingSep 16, 2023
  14. Junio C HamanoSep 16, 2023
  15. Jeff KingSep 16, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.