git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [filter-repo PATCH] fix links to git-fast-import

From
Elijah Newren <newren@gmail.com>
Date
Sep 25, 2022, 00:08 UTC
Message-ID
<CABPp-BFwJr7xLhdbdbh+eFhaSF36cLEzKbzc7gpuit=iC2Eejg@mail.gmail.com>
In-Reply-To
<Yy+GzB0gTBHaJJw1@pobox.com>
On Sat, Sep 24, 2022 at 3:38 PM Todd Zullinger <tmz@pobox.com> wrote:
Show 61 quoted lines
>
> Hi,
>
> Elijah Newren wrote:
> > On Fri, Sep 23, 2022 at 8:37 PM Todd Zullinger <tmz@pobox.com> wrote:
> >> I noticed the link to git-fast-import.html in git-filter-repo.html was
> >> missing the `git-` prefix.  The man page similarly lacked it when
> >> referencing it.
> >>
> >>  html/git-filter-repo.html | 2 +-
> >>  man1/git-filter-repo.1    | 2 +-
> >
> > Neither of these files are tracked; both are auto-generated.  I do
> > stuff them into the "docs" branch so people can grab them...but
> > they'll just be wiped out and overwritten the next time I build the
> > docs.  So, either the documentation source file is wrong, or the build
> > process is.
>
> D'oh! I should have looked closer at the build process.
> Somehow I saw the docs branch and just _assumed_ it was the
> source.  And that required looking right past the asciidoc
> version in Documentation/ on the main branch. ;)
>
> I was clearly a few too many tangents deep.
>
> > Is the real problem that in this text from Documentation/git-filter-repo.txt:
> >
> >     There are four callbacks that allow you to operate directly on raw
> >     objects that contain data that's easy to write in
> >     linkgit:fast-import[1] format:
> >
> > that there should be a "git-" on the last line?
>
> Indeed, thanks.
>
> This should work (I tested by symlinking git-filter-repo.txt
> to git's Documentation, as the Makefile does):
>
> -- 8< --
> Subject: [PATCH] git-filter-repo.txt: add missing `git-` prefix to fast-import
>  link
>
> Signed-off-by: Todd Zullinger <tmz@pobox.com>
> ---
>  Documentation/git-filter-repo.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/git-filter-repo.txt b/Documentation/git-filter-repo.txt
> index 9c00a78..09374a4 100644
> --- a/Documentation/git-filter-repo.txt
> +++ b/Documentation/git-filter-repo.txt
> @@ -1047,7 +1047,7 @@ instead of strings.
>
>  There are four callbacks that allow you to operate directly on raw
>  objects that contain data that's easy to write in
> -linkgit:fast-import[1] format:
> +linkgit:git-fast-import[1] format:
>
>  --------------------------------------------------
>  --blob-callback
> -- 8< --
Thanks, applied!
Previous: Todd Zullinger
Message 4 of 4 in “fix links to git-fast-import”
  1. fix links to git-fast-importTodd Zullinger, Sep 24, 2022
  2. Elijah NewrenSep 24, 2022
  3. Todd ZullingerSep 24, 2022
  4. Elijah NewrenSep 25, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.