git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] format-patch: improve handling of `format.notes`

From
Elijah Newren <newren@gmail.com>
Date
Dec 9, 2019, 21:42 UTC
Message-ID
<CABPp-BFstgQya9mKXdDVWkf=U_3RQqY=_+2MpZpw_u9ci+0mqA@mail.gmail.com>
In-Reply-To
<cover.1575896661.git.liu.denton@gmail.com>
On Mon, Dec 9, 2019 at 5:10 AM Denton Liu <liu.denton@gmail.com> wrote:
Show 14 quoted lines
>
> In this email[1], Elijah pointed out that the handling of multiple
> `format.notes` configurations could be buggy. If we had
> `format.notes = <ref1>`, `format.notes = false` and
> `format.notes = <ref2>`, the behaviour is ambiguous. This series uses
> the way `--notes=<ref1> --no-notes --notes=<ref2>` is handled as a model
> and structures the handling of `format.notes` in a similar manner,
> allowing one `format.notes = false` to override previous configs.
>
> Also, in the same email, it was pointed out that git_config() should be
> called before repo_init_revisions(). In 13cdf78094 (format-patch: teach
> format.notes config option, 2019-05-16), the order was reversed. This
> series changes it back such that git_config() is called before
> repo_init_revisions().

Sweet, thanks for working on this. I took a very cursory glance over the patches and didn't spot anything egregiously wrong, though I'm also not familiar with the notes machinery. Mostly I'm just piping up to thank you for tackling this so quickly. :-)

Previous: Junio C Hamano
Message 11 of 11 in “format-patch: improve handling of `format.notes`”
  1. 0/5 format-patch: improve handling of `format.notes`Denton Liu, Dec 9, 2019
  2. 1/5 notes: rename to load_display_notes()Denton Liu, Dec 9, 2019
  3. 2/5 notes: create init_display_notes() helperDenton Liu, Dec 9, 2019
  4. 3/5 notes: extract logic into set_display_notes()Denton Liu, Dec 9, 2019
  5. Eric SunshineDec 9, 2019
  6. Denton LiuDec 9, 2019
  7. Philip OakleyDec 10, 2019
  8. 4/5 format-patch: use --notes behavior for format.notesDenton Liu, Dec 9, 2019
  9. 5/5 format-patch: move git_config() before repo_init_revisions()Denton Liu, Dec 9, 2019
  10. Junio C HamanoDec 9, 2019
  11. Elijah NewrenDec 9, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.